Add Apple Silicon (MPS) support #264
Conversation
this has prebuilt wheels for apple silicon. bump numpy from 1.26 to 1.26.4 to meet dependency requirements for decord2
Allows systems without CUDA to fallback to CPU.
The pin_memory() optimization is only available for CUDA backends.
…nd PostProcessAPIVideo
CUDA handles this internally but we need to handle it directly for CPU
…or cpu introduce workarounds for torch operations not available on mps like repeats of complex tensors
forcefully flush pending operations with synchronize and empty the cache.
meta-cla
bot
added
the
CLA Signed
mattiagaggi
left a comment
mattiagaggi
left a comment
There was a problem hiding this comment.
this seems to overlap with your other pull request :)
Also I'd make some tests
|
This is a continuation of the other PR. I just didn't want to clutter things when I didn't know yet how hard MPS support was going to be. I can add the end-to-end test for the video predictor to the PR but didn't want to pollute your repo. Is there a place you would like tests to go? |
|
@drduhe do you know why the import is stuck? i noticed the same with my other PR which was approved a week(?) ago? |
@provos I am not a maintainer on the project so it probably needs to get approval from someone with more pull than I have =). But FWIW I did create a tests directory as part of my PR as a starting point for where we can put unit tests. @mattiagaggi might have more information on the process, SLA, and workflow requirements. |
|
It would be great to have this merged... |
|
@provos this looks awesome! I currently maintain my own custom implementation for this, but I'd love to deprecate it in favor of this upstream solution. Is this waiting on anything specific, or is it just pending review? |
|
It seems that the folks managing this repository take a while to churn through the open PRs to provide feedback or approvals and the queue is actually increasing quite a bit weekly - but that could be due to the holidays and the start of the new year, along with the fact that most of that group are more academically focused it seems. I have reached out to several of the folks who are owners own the repository to see if there would be a way we could get more people added to this group so that we get a bit faster turn around. I for one, would be super happy to contribute in this capacity, but I haven't gotten a response yet. I would like to see this package get some love and regular attention as it has a ton of interest from the community. If we can get some buy in or increased velocity from the managing team it would be awesome, if not perhaps we could set up a more community focused fork of this repository that would proctor ourselves =) |
|
@dario-k somebody at Meta/FAIR has to approve this. It does not seem that anyone from there has looked at this PR. |
5 participants
Adds MPS device support for both image and video predictors on Apple Silicon.
Changes:
Performance of the Video predictor: